Code review comment for lp://staging/~stevanr/linaro-ci-dashboard/refactor-build-list

Revision history for this message
Milo Casagrande (milo) wrote :

On Mon, Aug 27, 2012 at 5:30 PM, Milo Casagrande
<email address hidden> wrote:
>
> On Mon, Aug 27, 2012 at 5:17 PM, Stevan Radaković
> <email address hidden> wrote:
>>
>> from django.contrib.auth.decorators import login_required
>> +from django.shortcuts import render_to_response
>> +from django.template import RequestContext
>> from django.views.generic.detail import DetailView
>>
>> def render_to_response(self, context):
>> if self.request.is_ajax():
>> - build = self.object.schedule_build()
>> - return JSONResponseMixin.render_to_response(self, build)
>> + data = {
>> + "build" : self.object.schedule_build()
>> + }
>> + template = "build.html"
>> + return render_to_response(template, data, context_instance = RequestContext(self.request))

Forgot to say: at least cut down under 80 chars that line. :-)

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal