Qreator

Merge lp://staging/~stefan-schwarzburg/qreator/fix_bug_1006635 into lp://staging/~dpm/qreator/trunk

  1. fix_bug_1006635
  2. Merge into trunk
Proposed by Schwarzburg
Status: Rejected
Rejected by: David Planella
Proposed branch: lp://staging/~stefan-schwarzburg/qreator/fix_bug_1006635
Merge into: lp://staging/~dpm/qreator/trunk
Diff against target: 140 lines (+45/-37)
2 files modified
data/ui/QreatorWindow.ui (+29/-10)
qreator/QreatorWindow.py (+16/-27)
To merge this branch: bzr merge lp://staging/~stefan-schwarzburg/qreator/fix_bug_1006635
Reviewer Review Type Date Requested Status
David Planella Disapprove
Review via email: mp+108393@code.staging.launchpad.net

Description of the change

The qrcode types were created as IconView items. This however seems to be contraintuitive to some users, because they do not behave like buttons.
This branch changes this by actually making them buttons and placing them in a grid.
The buttons contain Images and Labels in a Box(orientation=vertical) to mimik the IconView behaviour.

This might lead to different behaviour, especially the placing of the icons, the resize behaviour etc. but it might still look good enough :-)

To post a comment you must log in.
Revision history for this message
Schwarzburg (stefan-schwarzburg) wrote :

I have added a far less invasive option to fix the bug (in another branch). So you can decide which one you like more.

Revision history for this message
David Planella (dpm) wrote :

Thanks a lot for your work. I don't feel very well rejecting something you've put quite a lot of effort into, but given the choice, I think I prefer the approach on the other branch you are proposing.

Thus I'll mark this one as rejected and I'll start reviewing lp:~stefan-schwarzburg/qreator/fix_bug_1006635_selection later on today.

review: Disapprove
Revision history for this message
David Planella (dpm) wrote :

Thanks again for the work on this. As I've just merged your other branch that essentially supersedes this one, would you mind marking this branch as obsolete, so that it does not appear in the list of merge proposals to review?

Revision history for this message
Schwarzburg (stefan-schwarzburg) wrote :

I would love to mark this obsolete, but I can't find any way to do this... Any hints?

Revision history for this message
David Planella (dpm) wrote :

Al 07/06/12 21:08, En/na Schwarzburg ha escrit:
> I would love to mark this obsolete, but I can't find any way to do this... Any hints?

Sure, sorry, I should have been more detailed.

If you go to the branch URL [1], you should see a 'Change details' link.
There you can mark the branch as 'Abandoned'.

Here's the direct link [2].

I hope this helps.

[1]: https://code.launchpad.net/stefan-schwarzburg/qreator/fix_bug_1006635/
[2]:
https://code.launchpad.net/stefan-schwarzburg/qreator/fix_bug_1006635/+edit

Unmerged revisions

82. By Schwarzburg

replaced the IconView for the QRCode types with a grid of buttons

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: