Ubuntu
likewise-open package

Merge lp://staging/~ssalley/ubuntu/oneiric/likewise-open/likewise-open-fix-845477 into lp://staging/ubuntu/oneiric/likewise-open

  1. Oneiric (11.10)
  2. likewise-open-fix-845477
  3. Merge into oneiric
Proposed by Scott Salley
Status: Merged
Merge reported by: James Page
Merged at revision: not available
Proposed branch: lp://staging/~ssalley/ubuntu/oneiric/likewise-open/likewise-open-fix-845477
Merge into: lp://staging/ubuntu/oneiric/likewise-open
Diff against target: 2230 lines (+2210/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/config-fixes-for-verbose-make.patch (+2202/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~ssalley/ubuntu/oneiric/likewise-open/likewise-open-fix-845477
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Information
Ubuntu branches Pending
Review via email: mp+75067@code.staging.launchpad.net

Description of the change

likewise-open recently dropped the use of autotools for Likewise developed components and moved to makekit. In the previous build system, someone used sed for processing some files during the build instead of using standard AC_CONFIG_FILES. This deficiency was preserved with the move to makekit. However, makekit makes much greater use of make and adding V=1 (verbose) to the make command line introduced a bug.

I've modified the build process to use mk_output_file (roughly like AC_CONFIG_FILES) to correct this. Removing V=1 from the make command line would also have worked, but that didn't feel like the right fix.

To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Scott, this looks pretty big as a patch, I'd like to be able to track its progress into upstream before adding it to Ubuntu. Can you add a 'Bug:' header to the patch with a link to the upstream submission?

Also its not clear, does the package build incorrectly, or not at all, without this patch?

review: Needs Information
Revision history for this message
Scott Salley (ssalley) wrote :

Regarding the size of the patch, most of it is because several files were renamed from whatever.sh to whatever.sh.in.

Without this patch, the package builds but does not function properly after install. Note that just removing 'V=1' from make would 'fix' things.

Regarding the 'Bug:', the upstream bug database is not exposed. I have checked the change in to our main branch, but I don't expect it to propagate to the public site very soon. But I will try to expedite that.

Are there other things I could do to help get this patch reviewed?

Note that we are in the process of shutting down our operations. Half of 'Likewise' was acquired by BeyondTrust in July and we are now moving offices. A lot of our servers are going offline and I will be offline in a few days. It is estimated to be a few weeks before we will be functional again.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: