Code review comment for lp://staging/~spiv/bzr/tags-commit-propagation-603395-2.2

Revision history for this message
Andrew Bennetts (spiv) wrote :

mgz: Heh, I agree about the duplication... so much so that I'd already done something about it, but I'd forgotten to push! Have pushed now. Please take another look and let me know what you think. Some assertions have been moved out of run_script too, to innoculate against future changes in the command output that are irrelevant to the purpose of the tests.

I'm happy to take care of tweaking the run_script invocation when merging up to trunk — with the much shorter run_script segments I have now that should be a pretty small change.

« Back to merge proposal