Code review comment for lp://staging/~spiv/bzr/tags-commit-propagation-603395-2.2

Revision history for this message
John A Meinel (jameinel) wrote :

I think having the news entry saying it propagates "new" tags is misleading. It propagates all tags. (Imagine the master deleted a tag, we'll put it back at this point.)

Anyway the change seems fine, though it seems like it would supersede the other. (rather than have it done at merge time, have it done at commit time seems a better tradeoff. Would be even better if we staged tag changes into the working tree, rather than auto-committing to the branch.)

So, I like this patch more than the other one, just needs a tweak on the NEWS entry.

review: Needs Fixing

« Back to merge proposal