Code review comment for lp://staging/~soren/nova/virt-test-improvements

Revision history for this message
Brian Lamar (blamar) wrote :

Two quick code comments:

43 === added file 'nova/image/service.py'

I think this is a remnant of the past, it was moved in trunk a bit ago. I think it might have been left after a trunk merge.

1841 + try:
1842 + virt_dom = self._lookup_by_name(instance['name'])
1843 + except exception.InstanceNotFound:
1844 + raise exception.InstanceNotRunning()

Why change the exception type here? Seems like an InstanceNotFound exception makes more sense to me.

« Back to merge proposal