Two quick code comments:
43 === added file 'nova/image/service.py'
I think this is a remnant of the past, it was moved in trunk a bit ago. I think it might have been left after a trunk merge.
1841 + try: 1842 + virt_dom = self._lookup_by_name(instance['name']) 1843 + except exception.InstanceNotFound: 1844 + raise exception.InstanceNotRunning()
Why change the exception type here? Seems like an InstanceNotFound exception makes more sense to me.
« Back to merge proposal
Two quick code comments:
43 === added file 'nova/image/ service. py'
I think this is a remnant of the past, it was moved in trunk a bit ago. I think it might have been left after a trunk merge.
1841 + try: by_name( instance[ 'name'] ) InstanceNotFoun d: InstanceNotRunn ing()
1842 + virt_dom = self._lookup_
1843 + except exception.
1844 + raise exception.
Why change the exception type here? Seems like an InstanceNotFound exception makes more sense to me.