Code review comment for lp://staging/~sophron/postorius/create_users
Revision history for this message
| Richard Wackerbarth (wacky) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
Isn't the visibility of the list members a per_list policy setting?
In any case, we will need to have list administrators (who are not the superuser) be able to see the membership on their list.
I think that Postorius will require a better model for roles.
Richard
On Oct 25, 2012, at 3:19 AM, Florian Fuchs <email address hidden> wrote:
> Review: Approve
>
> Hi George,
>
> thank you for your changes (and the bug reports)! I have just merged them to the trunk. I only made some very small changes and additions (adjusted the docstring in MailmanUserView, added the user icon, some PEP8 fixes...). I also made the user list and details only available to superusers (I don't think every user should be able to see who else is there...).