Code review comment for lp://staging/~smspillaz/compiz-libcompizconfig/ccs-object

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I don't like the style of coding in ccsObjectAddInterface() - if either realloc fails then the object is hosed. Admittedly FALSE is returned to inform the caller, but I'd prefer the object to remain viable and just the call to fail. Anything else can cause nasty surprises in client code. (Admittedly, if realloc fails there are probably worse problems to deal with.)

review: Needs Fixing

« Back to merge proposal