Compiz Animations Plugin

Merge lp://staging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469_abi_safe into lp://staging/compiz-animation-plugin

  1. compiz-animation-plugin.fix_976469_abi_safe
  2. Merge into 0.9.5
Proposed by Sam Spilsbury
Status: Rejected
Rejected by: Sam Spilsbury
Proposed branch: lp://staging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469_abi_safe
Merge into: lp://staging/compiz-animation-plugin
Diff against target: 199 lines (+14/-15)
9 files modified
include/animation/animeffect.h (+4/-2)
include/animation/fade.h (+0/-1)
include/animation/grid.h (+0/-2)
include/animation/gridtransform.h (+0/-1)
include/animation/transform.h (+0/-1)
src/animation.cpp (+7/-1)
src/fade.cpp (+1/-0)
src/private.h (+0/-7)
src/zoomside.cpp (+2/-0)
To merge this branch: bzr merge lp://staging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469_abi_safe
Reviewer Review Type Date Requested Status
Sam Spilsbury Disapprove
Daniel van Vugt Needs Fixing
Review via email: mp+102023@code.staging.launchpad.net

Description of the change

Turns out that compiz-plugins-extra uses the Animation class, so we can't add virtual functions to it. Backs out the change that added virtual functions and uses a dptr method instead to determine whether or not we need to set the transformed window mask.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

smspillaz just said this fix is no longer required. They're going to just rebuild compiz-plugins-extra.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also, this branch appears to cause a weird regression: When minimizing/restoring nautilus or thunderbird windows I get strange flickering. And during the animation/flickering the original rectangular window itself flickers too.

That's with the default animation settings (magic lamp?)

review: Needs Fixing
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

No longer required

review: Disapprove

Unmerged revisions

398. By Sam Spilsbury

Fix 976469 without breaking the ABI

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches