lp://staging/~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469_abi_safe

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://staging/compiz-animation-plugin

Sam Spilsbury: Disapprove on 2012-04-16

Daniel van Vugt: Needs Fixing on 2012-04-16

Diff: 199 lines (+14/-15)

9 files modified

include/animation/animeffect.h (+4/-2)
include/animation/fade.h (+0/-1)
include/animation/grid.h (+0/-2)
include/animation/gridtransform.h (+0/-1)
include/animation/transform.h (+0/-1)
src/animation.cpp (+7/-1)
src/fade.cpp (+1/-0)
src/private.h (+0/-7)
src/zoomside.cpp (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #976469: Menu bar - Shadows are not clipped until animations are finished

Medium

Fix Released

Link a bug report

Related blueprints

398. By Sam Spilsbury on 2012-04-15

Fix 976469 without breaking the ABI

397. By Sam Spilsbury on 2012-04-10

Don't increment the destroy ref count of a window unless an animation is
active. (LP: #940603)

It doesn't make any sense to increase the destroy reference count of a window
on CompWindowNotifyBeforeDestroy based on whether or not an an animation for
that window "could" be allowed - CompWindowNotifyBeforeDestroyed is called
on CompWindow::destroy (which under sane circumstances, should only ever be
called when the window is either reparented away from its parent or the root
window or when the window is destroyed).

In this case, we deregister all events on the window so it isn't possible to
determine through any normal means that a close animation is going to activate
on the window. And in any event, the unmap which causes close animations
always comes before the DestroyNotify or ReparentNotify anyways.

Even if the CompWindowNotifyClose were to somehow come after the window
received a ReparentNotify or DestroyNotify, the tradeoff then comes between
not playing animations for those corner case windows or keeping ghost windows
on screen because we kept a destroy reference and never got rid of it. In this
case, it is more sane to do the former.

396. By Sam Spilsbury on 2012-04-10

Added a flag to specify whether an animation actually needs a transformed
window. (LP: #976469)

395. By Daniel van Vugt on 2012-03-21

Fix stuttering animations on large/fullscreen windows by using the higher
performance rendering method (full screen damage). (LP: #930192)

394. By Sam Spilsbury on 2012-01-21

Merge lp:~vanvugt/compiz-animation-plugin/fix-915236

393. By Sam Spilsbury on 2011-10-03

Merge

392. By Sam Spilsbury on 2011-10-03

lp:~compiz-team/compiz-animation-plugin/compiz-animation-plugin.fix_864476

391. By Sam Spilsbury on 2011-09-19

Merge

390. By Sam Spilsbury on 2011-09-19

Merge

389. By Sam Spilsbury on 2011-09-18

Merge