Merge lp://staging/~sjakthol/compiz/fix-878516 into lp://staging/compiz/0.9.9
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | 3573 |
Merged at revision: | 3578 |
Proposed branch: | lp://staging/~sjakthol/compiz/fix-878516 |
Merge into: | lp://staging/compiz/0.9.9 |
Diff against target: |
203 lines (+65/-31) 2 files modified
plugins/grid/src/grid.cpp (+64/-30) plugins/grid/src/grid.h (+1/-1) |
To merge this branch: | bzr merge lp://staging/~sjakthol/compiz/fix-878516 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
MC Return | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email:
|
Commit message
Grid: Correctly restore semi-maximized windows.
Changes include:
1) Remove the special status of fully maximized windows - it just adds
complexity to the restoration process. Core can handle the
restoration of maximized windows perfectly well.
2) Catch un-maximation of a gridded semi-maximized window in
stateChangeN
3) Refactor restoreWindow to work with semi-maximized windows.
This fixes LP: #878516 and also LP: #925867 as a side effect.
Description of the change
NOTE: These fixes cause bug 1102024 to also manifest itself with semi-maximized terminal windows. Previously isGridMaximized wasn't unset once a semi-maximized window was restored as the restoration code was never called. Consequently validateResizeR
I'm not sure whether it's worth fixing an annoying bug 878516 affecting every application by introducing another annoying bug that only affects one application. But anyways I'm putting my work up here if someone wants to take a shot at fixing the regression because I'm out of ideas...
Top job !
Works like expected and announced.
Makes those nasty mouse-resized grid windows much more usable.
Strange thing with the terminal windows though, but still a huge improvement of grid.