lp://staging/~sjakthol/compiz/fix-878516

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/compiz/0.9.9 at revision 3578

Daniel van Vugt: Approve on 2013-01-23

MC Return: Approve on 2013-01-22

PS Jenkins bot: Pending (continuous-integration) requested 2013-01-23

Diff: 203 lines (+65/-31)

2 files modified

plugins/grid/src/grid.cpp (+64/-30)
plugins/grid/src/grid.h (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #878516: Window management - Restoring a grid-placed window by dragging the title bar downwards does not restore the original window width	High	Fix Released
Bug #925867: [regression] Window resize granularity is lost when restored after using Grid	Medium	Fix Released

Link a bug report

Related blueprints

3573. By Sami Jaktholm on 2013-01-23

Change assert.h to cassert

3572. By Sami Jaktholm on 2013-01-22

Filter non-maximation related states from lastState before comparing it to VertMask.

3571. By Sami Jaktholm on 2013-01-21

isGridMaximized changed to isGridSemiMaximized and comment added about core handling fully maximized windows. Added assert to the else clause in restoreWindow, changed shifts to divide by 2 and added check for xwcm before calling sendSyncRequest. Also added an extra check so that we only call restoreWindow from stateChangeNotify if lastState was CompWindowStateMaximizedVertMask (e.g. not a fully maximized window incorrectly marked as isGridSemiMaximized).

3570. By Sami Jaktholm on 2013-01-20

Grid: Correctly restore semi-maximized windows.

Changes include:
1) Remove the special status of fully maximized windows - it just adds
   complexity to the restoration process. Core can handle the
   restoration of maximized windows perfectly well.
2) Catch un-maximation of a gridded semi-maximized window in
   stateChangeNotify and call restoreWindow to revert the changes.
3) Refactor restoreWindow to work with semi-maximized windows.

This fixes bug 878516 and also bug 925867 as a side effect.

3569. By Sam Spilsbury on 2013-01-19

Don't set _NET_DESKTOP_GEOMETRY until we've set the default viewport size. (LP: #1096455). Fixes: https://bugs.launchpad.net/bugs/1096455.

Approved by Daniel van Vugt, PS Jenkins bot.

3568. By Brandon Schaefer on 2013-01-19

Adds an animation to the grid plugin. The animation takes the current window,
renders it to the growing grid box and slowly fades out into the default
orange glow box.

Also adds 2 options ccsm for the grid, one to turn this animation off, and
another to change the grid animation duration.

This also changes the default grid duration from 250 ms, to 350ms.

(LP: #689792). Fixes: https://bugs.launchpad.net/bugs/689792.

Approved by Daniel van Vugt, PS Jenkins bot, Brandon Schaefer, MC Return.

3567. By Sam Spilsbury on 2013-01-18

Supress g_signal_new leaks. Signals aren't freed.

(LP: #1097649). Fixes: https://bugs.launchpad.net/bugs/1097649.

Approved by Daniel van Vugt, PS Jenkins bot.

3566. By Sam Spilsbury on 2013-01-18

Make freeing the returned lists the responsibility of the caller. Don't
auto-free them in the tests. (LP: #1100539). Fixes: https://bugs.launchpad.net/bugs/1100539.

Approved by Daniel van Vugt, PS Jenkins bot.

3565. By PS Jenkins bot on 2013-01-17

Releasing 1:0.9.9~daily13.01.17-0ubuntu1 to ubuntu.

Approved by .

3564. By MC Return on 2013-01-16

Workspacenames plugin:
Workspace Naming requires the text plugin to work.

(LP: #1100172). Fixes: https://bugs.launchpad.net/bugs/1100172.

Approved by Daniel van Vugt, Sam Spilsbury.