Code review comment for lp://staging/~sinzui/launchpad/webkit-css

This is my branch fix the CSS rules for webkit and remove obsolete styles.

    lp:~sinzui/launchpad/webkit-css
    Diff size: 168
    Launchpad bug: https://bugs.launchpad.net/bugs/498574
                   https://bugs.launchpad.net/bugs/498581
                   https://bugs.launchpad.net/bugs/435768
                   https://bugs.launchpad.net/bugs/185306
    Test command: None.
    Pre-implementation: danilo/bac for 1, salgado for 2, beuno 3. no one 4.
    Target release: 3.1.13

= fix the CSS rules for webkit =

Bug #498574 [page layout broken in webkit]
    The CSS rules needed by webkit were broken when the obsolete CSS was
    removed from style-3.0.css--something was not obsolete.

Bug #498581 [restore the timeline stylesheet]
    The timeline was broken in a recent landing because the CSS was removed.
    It was loading the wrong CSS file. It needs the new CSS macro to center
    the timeline and fix zoom in / zoom out.

Bug #435768 [footer font size is too large "This site is running ..."]
    The "This site is running pre-release code ..." message is 13px, but the
    rest of the footer is 11px. This may be fixable by removing the styles so
    that re default styles of the footer takes precedence.

Bug #185306 [portlets, portlets_one, and portlets_two slots are redundant]
    These slots are not used by base-layout, they are not being used.

== Rules ==

Bug #498574 [page layout broken in webkit]
    Restore one of the old #maincontent rules.

Bug #498581 [restore the timeline stylesheet]
    Use the new stylesheet macro to fix the formatting of the timeline
    elements that are created by the script.

Bug #435768 [footer font size is too large "This site is running ..."]
    Remove the font-size instruction.

Bug #185306 [portlets, portlets_one, and portlets_two slots are redundant]
    Remove the unused slots.

== QA ==

Bug #498574 [page layout broken in webkit]
    * View a project page in gecko and webkit and verify that both pages
      show the portlets in the correct place to the right.

Bug #498581 [restore the timeline stylesheet]
    * View a project.
      * Verify the timeline content is centered in its portlet.
      * Verify you see the zoom control when your mouse is over the timeline.

Bug #435768 [footer font size is too large "This site is running ..."]
    * View any page on edge or staging
      * Verify that the site message is the same size as the tour text.

Bug #185306 [portlets, portlets_one, and portlets_two slots are redundant]
    * None, the content is not used.

== Lint ==

Lint reported an obsolete slot in a bug template I was looking at. I removed
all occurrences of the pageheading and portlet slots from main-template.pt
(which was removed last month).

Linting changed files:
  lib/canonical/launchpad/icing/style-3-0.css
  lib/canonical/launchpad/icing/style.css
  lib/lp/bugs/templates/bugtarget-bugs.pt
  lib/lp/bugs/templates/bugtask-edit.pt
  lib/lp/bugs/templates/bugtask-view.pt
  lib/lp/bugs/templates/cveset-all.pt
  lib/lp/registry/templates/object-timeline-graph.pt

== Test ==

None. This changes are visual, or in the case of obsolete content, not
visual.

== Implementation ==

    * lib/canonical/launchpad/icing/style-3-0.css
      * Restored the float: left; clear: both; rules needed by webkit/
      * Moved the site message rule to the current css rules and removed
        the font-size exception.
      * Moved the timeline styles to the current css--the markup generated
        by the script needs them.
    * lib/canonical/launchpad/icing/style.css
      * Removed styles that were moved to the current css.
    * lib/lp/registry/templates/object-timeline-graph.pt
      * Added the stylesheet macro to the timeline template so that the
        iframe gets all the style rules.

    * lib/lp/bugs/templates/bugtarget-bugs.pt
    * lib/lp/bugs/templates/bugtask-edit.pt
    * lib/lp/bugs/templates/bugtask-view.pt
    * lib/lp/bugs/templates/cveset-all.pt
      * Removed obsolete slots that are not rendered.