Code review comment for lp://staging/~sinzui/launchpad/question-email-1

Revision history for this message
j.c.sackett (jcsackett) wrote :

Looks good to land.

I have a minor quibble in a comment (that I guess I missed when reviewing your previous branch.

class IQuestionEmailJobSource(IJobSource):
     """An interface for acquiring IQuestionJob."""

- def create(question, user, subject, body, headers):
+ def create(question, user, recipient_set, subject, body, headers):
         """Create a new IQuestionJob.

         :param question: An `IQuestion`.
         :param user: An `IPerson`.
+ :param recipient_set: A `QuestionRecipientSet`.
         :param subject: A'The subject of the email.

That param should be ":param subject: The user of the email." Looks like just a minor typo.

This is *obviously* not a blocker to land. :-P

review: Approve

« Back to merge proposal