I have a minor quibble in a comment (that I guess I missed when reviewing your previous branch.
class IQuestionEmailJobSource(IJobSource):
"""An interface for acquiring IQuestionJob."""
- def create(question, user, subject, body, headers):
+ def create(question, user, recipient_set, subject, body, headers):
"""Create a new IQuestionJob.
:param question: An `IQuestion`.
:param user: An `IPerson`.
+ :param recipient_set: A `QuestionRecipientSet`.
:param subject: A'The subject of the email.
That param should be ":param subject: The user of the email." Looks like just a minor typo.
Looks good to land.
I have a minor quibble in a comment (that I guess I missed when reviewing your previous branch.
class IQuestionEmailJ obSource( IJobSource) :
"""An interface for acquiring IQuestionJob."""
- def create(question, user, subject, body, headers):
+ def create(question, user, recipient_set, subject, body, headers):
"""Create a new IQuestionJob.
:param question: An `IQuestion`. entSet` .
:param user: An `IPerson`.
+ :param recipient_set: A `QuestionRecipi
:param subject: A'The subject of the email.
That param should be ":param subject: The user of the email." Looks like just a minor typo.
This is *obviously* not a blocker to land. :-P