Launchpad itself

Code review comment for lp://staging/~sinzui/launchpad/pillar-portlets

pillar-portlets
Merge into devel

Revision history for this message

Curtis Hovey (sinzui) wrote on 2009-08-31:

This is my branch to fix involvement links.

    lp:~sinzui/launchpad/pillar-portlets
    Diff size: 53
    Launchpad bug: https://bugs.launchpad.net/bugs/416125
                   https://bugs.launchpad.net/bugs/418548
                   https://bugs.launchpad.net/bugs/421899
    Test command: ./bin/test -vvt "pillar-views"
    Pre-implementation: no-one, I trust the bug reporters
    Target release: 3.1.0

= Fix involvement links and official portlets =

Bug 416125 [product homepage's submit code link leads to +filebug]
The link is to file a bug, not register a branch.

Bug 418548 [Help translate" link in Get involved portlet is broken]
The link is missing the pillar; it goes to the root.

Bug 421899 [register a blueprint" leads to a 404 on edge]
The link is register a branch, not a spec.

== Rules ==

Bug 416125 [product homepage's submit code link leads to +filebug]
* Change the link to +addbranch.

Bug 418548 [Help translate" link in Get involved portlet is broken]
* Replace '/' with '' because the former removes the context from
the URL.

Bug 421899 [register a blueprint" leads to a 404 on edge]
* Change the link to +addspec.

== QA ==

Bug 416125 [product homepage's submit code link leads to +filebug]
* Visit https://edge.launchpad.net/epidermis
* Verify that the submit code link goes to +addbranch

Bug 418548 [Help translate" link in Get involved portlet is broken]
    * Visit https://edge.launchpad.net/epidermis
    * Verify that the submit code link goes to
      https://translate.edge.launchpad.net/epidermis

Bug 421899 [register a blueprint" leads to a 404 on edge]
* Visit https://edge.launchpad.net/epidermis
* Verify that the register a blueprint link goes to +addspec

== Lint ==

Linting changed files:
lib/lp/registry/browser/pillar.py
lib/lp/registry/browser/tests/pillar-views.txt

== Test ==

    * lib/lp/registry/browser/tests/pillar-views.txt
      * Added a test of the entire menu. The tests for whether a link
        is enabled are fine, but there was not a test to verify the target.

== Implementation ==

* lib/lp/registry/browser/pillar.py
* Fixed the target param of three links.

This is my branch to fix involvement links.

= Fix involvement links and official portlets =

Bug 416125 [product homepage's submit code link leads to +filebug]
    The link is to file a bug, not register a branch.

Bug 418548 [Help translate" link in Get involved portlet is broken]
    The link is missing the pillar; it goes to the root.

Bug 421899 [register a blueprint" leads to a 404 on edge]
    The link is register a branch, not a spec.

== Rules ==

Bug 416125 [product homepage's submit code link leads to +filebug]
    * Change the link to +addbranch.

Bug 418548 [Help translate" link in Get involved portlet is broken]
    * Replace '/' with '' because the former removes the context from
      the URL.

Bug 421899 [register a blueprint" leads to a 404 on edge]
    * Change the link to +addspec.

== QA ==

Bug 416125 [product homepage's submit code link leads to +filebug]
    * Visit https://edge.launchpad.net/epidermis
    * Verify that the submit code link goes to +addbranch

Bug 421899 [register a blueprint" leads to a 404 on edge]
    * Visit https://edge.launchpad.net/epidermis
     * Verify that the register a blueprint link goes to +addspec

== Lint ==

Linting changed files:
  lib/lp/registry/browser/pillar.py
  lib/lp/registry/browser/tests/pillar-views.txt

== Test ==

* lib/lp/registry/browser/tests/pillar-views.txt
      * Added a test of the entire menu. The tests for whether a link
        is enabled are fine, but there was not a test to verify the target.

== Implementation ==

* lib/lp/registry/browser/pillar.py
      * Fixed the target param of three links.

« Back to merge proposal