Code review comment for lp://staging/~sinzui/launchpad/not-packaged-0

Hi Curtis,

This change looks very good. Thank you for your persistence in
getting it done.

On IRC I suggested a quiet period equal to the Ubuntu release
schedule, i.e. six months rather than twelve. What was your thinking
for twelve?

> === modified file 'lib/lp/registry/browser/product.py'
> --- lib/lp/registry/browser/product.py 2010-04-14 17:16:56 +0000
> +++ lib/lp/registry/browser/product.py 2010-04-19 18:53:16 +0000
> @@ -44,8 +44,11 @@
>
>
> from cgi import escape
> +from datetime import datetime, timedelta
> from operator import attrgetter
>
> +import pytz
> +
> from zope.component import getUtility
> from zope.event import notify
> from zope.app.form.browser import TextAreaWidget, TextWidget
> @@ -1047,6 +1050,7 @@
> suggestions = None
> max_suggestions = 8
> other_package = object()
> + not_packaged = object()
>
> @cachedproperty
> def sourcepackages(self):
> @@ -1064,8 +1068,10 @@
> return True
> if self.user is None or config.launchpad.is_lpnet:
> return False
> - else:
> - return True
> + next_suggest_packaging_date = self.context.next_suggest_packaging_date
> + return (
> + next_suggest_packaging_date is None
> + or next_suggest_packaging_date < datetime.now(tz=pytz.UTC))

I think <= might be better.

> @property
> def initial_values(self):