Code review comment for lp://staging/~sinzui/juju-release-tools/tarfile-agent-arch

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

There are lint errors in trunk.

./agent_archive.py:110:81: E501 line too long (98 > 80 characters)
./agent_archive.py:113:81: E501 line too long (101 > 80 characters)
./agent_archive.py:178:14: E231 missing whitespace after ','
./agent_archive.py:178:81: E501 line too long (82 > 80 characters)
./make_image_streams.py:10:1: E402 module level import not at top of file
./make_image_streams.py:11:1: E402 module level import not at top of file
./make_image_streams.py:12:1: E402 module level import not at top of file
./make_image_streams.py:13:1: E402 module level import not at top of file
./make_image_streams.py:15:1: E402 module level import not at top of file
./make_image_streams.py:16:1: E402 module level import not at top of file
./make_image_streams.py:22:1: E402 module level import not at top of file
./make_image_streams.py:26:1: E402 module level import not at top of file

Are the directions in setup_cross_building still correct?

review: Approve

« Back to merge proposal