Code review comment for lp://staging/~sinzui/juju-ci-tools/azure-arm-ha

Revision history for this message
Aaron Bentley (abentley) wrote :

This looks good.

One small thing: In the test data, I try to avoid reusing variable names as their value, e.g. {'subscription-id': 'subscription-id'}, to avoid the class of problem where value was supposed to be used, but the name was used instead. I'll do {'subscription-id': 'subscription-id1'} instead.

review: Approve

« Back to merge proposal