Code review comment for lp://staging/~sinzui/ci-director/pub-win-jobs-be-resourceful

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Aaron.

I have made several simplifations largely from your encouragement to push the resourceful job detection into the state-file.
   * We can trust that sf.publication_jib, sf.get_build_windows_installer_job() and sf.get_windows_deploy_job()
     will return the job created by ResourcefulJob.
     * Note that I remove the guard for pub_job being None because it cannot be done when subordinate to
       if current_version is not None:
   * With my change to summary in my previous branch, the jobs are hashable so that I can use a set()
     to gather all jobs.
   * Reverted other changes to CIDirector and its tests since it didn't need extra logic to filter duplicate jobs.

« Back to merge proposal