lp://staging/~simpoir/landscape-client/fix_tempfile_cleaning

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~landscape/landscape-client/trunk at revision 917

🤖 Landscape Builder: Approve (test results) on 2016-08-19

Chris Glass (community): Approve on 2016-08-19

Benji York (community): Approve on 2016-08-18

Diff: 320 lines (+44/-43)

10 files modified

landscape/broker/tests/test_store.py (+2/-10)
landscape/lib/tests/test_persist.py (+7/-7)
landscape/manager/aptsources.py (+6/-1)
landscape/manager/scriptexecution.py (+3/-6)
landscape/monitor/tests/test_cephusage.py (+2/-4)
landscape/monitor/tests/test_usermonitor.py (+2/-3)
landscape/package/tests/test_changer.py (+1/-1)
landscape/tests/helpers.py (+18/-8)
landscape/tests/test_service.py (+1/-1)
landscape/tests/test_watchdog.py (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1603425: test_request_exit failing on trusty and precise

Undecided

Fix Committed

Link a bug report

Related blueprints

919. By Simon Poirier on 2016-08-19

address review nitpick

918. By Simon Poirier on 2016-08-17

lint

917. By Simon Poirier on 2016-08-17

replace shutil rmtree by os.unlink for files.
replace mkstemp by self-cleaning makeFile() makePersistFile() and makeDir(), where appropriate.
add some cleanup for some error cases that didn't.

916. By Andreas Hasenack on 2016-08-05

Bump debian changelog to 16.08. [trivial]

915. By Simon Poirier on 2016-07-25

Merge bug_1588404_swift_usage_report [f=1588404] [r=free.ekanayaka,landscape-builder,tealeg] [a=Simon Poirier]
This branch, primarily fixes #1588404 where swift units would not report
usage if the landscape-client unit happened to finish before swift-storage.
As uncaught errors in plugins would be silently discarded and stop looping
when the client is runned as a daemon, additional exception logging have been
added to the broker plugin as part of this branch.

914. By Alberto Donato on 2016-07-08

Merge drop-repository-helper [f=] [r=tribaal,adam-collard,landscape-builder] [a=Alberto Donato]
Drop the unused create_full_repository test helper.
It's no longer used in the server either.

913. By Andreas Hasenack on 2016-07-06

Merge libpam-systemd-depends-xenial-onwards [f=1590838] [r=landscape-builder,bogdana,ack,pitti] [a=Andreas Hasenack]
Add a libpam-systemd dependency to landscape-client if built on xenial or higher.

912. By Adam Collard on 2016-06-17

Merge drop-mocker [f=1592875] [r=bjornt,ack,landscape-builder] [a=Adam Collard]
Actually drop our copy of mocker.

Move makeFile and makeDir into LandscapeTest with slight tweaks to do the unconditional removal of files in cleanup (I used shutil.rmtree even if it's a file just to get a convenient ignore of errors for files that are removed by the tests themselves)

911. By Chad Smith on 2016-06-16

[tivial mocker retirement] [a=sparkiegeek, bbsw]

910. By Данило Шеган on 2016-06-16

Merge mock-tests-watchdog-middle [f=1592875] [r=landscape-builder,tealeg,adam-collard] [a=Данило Шеган]
Make a twisted mockery of landscape.tests.test_watchdog.DaemonTest.