Merge lp://staging/~simpoir/landscape-client/fix_tempfile_cleaning into lp://staging/~landscape/landscape-client/trunk

Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 919
Merged at revision: 917
Proposed branch: lp://staging/~simpoir/landscape-client/fix_tempfile_cleaning
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 320 lines (+44/-43)
10 files modified
landscape/broker/tests/test_store.py (+2/-10)
landscape/lib/tests/test_persist.py (+7/-7)
landscape/manager/aptsources.py (+6/-1)
landscape/manager/scriptexecution.py (+3/-6)
landscape/monitor/tests/test_cephusage.py (+2/-4)
landscape/monitor/tests/test_usermonitor.py (+2/-3)
landscape/package/tests/test_changer.py (+1/-1)
landscape/tests/helpers.py (+18/-8)
landscape/tests/test_service.py (+1/-1)
landscape/tests/test_watchdog.py (+2/-2)
To merge this branch: bzr merge lp://staging/~simpoir/landscape-client/fix_tempfile_cleaning
Reviewer Review Type Date Requested Status
Landscape Builder test results Approve
Chris Glass (community) Approve
Benji York (community) Approve
Review via email: mp+303189@code.staging.launchpad.net

Commit message

This branches does some cleanup in test tempfiles and fixes their broken
removal in test helpers.

Description of the change

This branches does some cleanup in test tempfiles and fixes their broken
removal in test helpers.

Testing instructions:

export TMP=$(mktemp -d)
trial -j8 landscape
ls $TMP

To post a comment you must log in.
Revision history for this message
Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 918
Branch: lp:~simpoir/landscape-client/fix_tempfile_cleaning
Jenkins: https://ci.lscape.net/job/latch-test/7857/

review: Approve (test results)
Revision history for this message
Benji York (benji) wrote :

Other than the inline, preexisting trivial, this branch looks good.

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

Nice! +1

(agree with Benji's point FWIW)

review: Approve
919. By Simon Poirier

address review nitpick

Revision history for this message
Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 919
Branch: lp:~simpoir/landscape-client/fix_tempfile_cleaning
Jenkins: https://ci.lscape.net/job/latch-test/7889/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: