Landscape Client

Merge lp://staging/~simpoir/landscape-client/fix_jenkins_tests_taking_too_long into lp://staging/~landscape/landscape-client/trunk

  1. fix_jenkins_tests_taking_too_long
  2. Merge into trunk
Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 919
Merged at revision: 918
Proposed branch: lp://staging/~simpoir/landscape-client/fix_jenkins_tests_taking_too_long
Merge into: lp://staging/~landscape/landscape-client/trunk
Prerequisite: lp://staging/~simpoir/landscape-client/fix_tempfile_cleaning
Diff against target: 15 lines (+3/-1)
1 file modified
landscape/tests/test_watchdog.py (+3/-1)
To merge this branch: bzr merge lp://staging/~simpoir/landscape-client/fix_jenkins_tests_taking_too_long
Reviewer Review Type Date Requested Status
Chad Smith Approve
Geoff Teale (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+303314@code.staging.launchpad.net

Commit message

bump max-retries for watchdog tests to avoid false negatives on slow test
setup on some jenkins slaves.

Description of the change

bump max-retries for watchdog tests to avoid false negatives on slow test
setup on some jenkins slaves.

Testing instructions:

This one is tricky to reproduce, as running the tests on the failing nodes
multiple times will make it succeed on the subsequent runs, until kernel
caches expires between runs (like scheduled jenkins runs).
I had some success reproducing by sync && echo 3 > /proc/sys/vm/cache_clear
before a run and adding an io limit to an lxd container, so it runs as slow
as jenkins machines.

To post a comment you must log in.
lp://staging/~simpoir/landscape-client/fix_jenkins_tests_taking_too_long updated
919. By Simon Poirier

bump watchdog retry to avoid failing when the test takes way to long to init on jenkins nodes.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 919
Branch: lp:~simpoir/landscape-client/fix_jenkins_tests_taking_too_long
Jenkins: https://ci.lscape.net/job/latch-test/7875/

review: Approve (test results)
Revision history for this message
Geoff Teale (tealeg) wrote :

+1, I've no objection to the content of the change - I guess we'll see if it makes a difference ;-)

review: Approve
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 on this change as well moving from 3 to 10 retries. Alternatively, I suppose we could have increased factor, but let's just see how this plays out.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: