Understood about the lack of unittests for the cli. Yes, this is a big tech-debt that we should eventually pay down.
Looking more closely at the change, it seems fine from visual inspection.
I have one concern about the ui though. I wonder if it would be better to call the option --keep-orphans. That's both more descriptive and avoid the double negatives.
Understood about the lack of unittests for the cli. Yes, this is a big tech-debt that we should eventually pay down.
Looking more closely at the change, it seems fine from visual inspection.
I have one concern about the ui though. I wonder if it would be better to call the option --keep-orphans. That's both more descriptive and avoid the double negatives.