Merge lp://staging/~shanemhansen/pyopenssl/dump_publickey into lp://staging/~exarkun/pyopenssl/trunk
Proposed by
Shane Hansen
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp://staging/~shanemhansen/pyopenssl/dump_publickey | ||||
Merge into: | lp://staging/~exarkun/pyopenssl/trunk | ||||
Diff against target: |
180 lines (+119/-1) 3 files modified
OpenSSL/crypto/crypto.c (+56/-0) OpenSSL/test/test_crypto.py (+54/-1) doc/api/crypto.rst (+9/-0) |
||||
To merge this branch: | bzr merge lp://staging/~shanemhansen/pyopenssl/dump_publickey | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jean-Paul Calderone | Needs Fixing | ||
Review via email: mp+125370@code.staging.launchpad.net |
Description of the change
This change implements the crypto.
There seem to be a number of api's for dumping public keys but I was able to match the PEM and ASN1 output with the openssl pkey tool which uses the PEM_write_
This is my first attempt at submitting something like this, so let me know on #pyopenssl if there's anything I can add. Thanks!
To post a comment you must log in.
Unmerged revisions
- 170. By Shane Hansen
-
Remove spurious print statement, incorrect exception statement,
and split up tests for dump_publickey. - 169. By Space Monkey
-
Implement crypto.
dump_publickey API (with tests)
Thanks. Some observations:
1. The switch in crypto_ dump_publickey has a default case that raises an exception with a message talking about FILETYPE_TEXT being a valid input, but there is no FILETYPE_TEXT case in the switch statement. publickey_ valid_filetype publickey_ valid_filetype split into two tests, one for FILETYPE_ASN1 and one for FILETYPE_PEM. publickey_ valid_filetype which should be deleted.
2. There's a `print` statement left in test_dump_
3. I'd like to see test_dump_
4. There's a bit of trailing whitespace after test_dump_
5. All APIs should be documented in doc/api/ as well.
Otherwise this looks good. Thanks!