Merge lp://staging/~sergiusens/snapcraft/1481122 into lp://staging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Leo Arias | ||||
| Approved revision: | 254 | ||||
| Merged at revision: | 252 | ||||
| Proposed branch: | lp://staging/~sergiusens/snapcraft/1481122 | ||||
| Merge into: | lp://staging/~snappy-dev/snapcraft/core | ||||
| Diff against target: |
1075 lines (+146/-292) 25 files modified
snapcraft/__init__.py (+3/-15) snapcraft/cmds.py (+9/-5) snapcraft/common.py (+1/-1) snapcraft/lifecycle.py (+9/-36) snapcraft/meta.py (+2/-5) snapcraft/plugins/ant.py (+4/-8) snapcraft/plugins/autotools.py (+6/-7) snapcraft/plugins/catkin.py (+12/-34) snapcraft/plugins/cmake.py (+3/-2) snapcraft/plugins/copy.py (+4/-10) snapcraft/plugins/go.py (+7/-9) snapcraft/plugins/make.py (+2/-2) snapcraft/plugins/maven.py (+4/-10) snapcraft/plugins/python2.py (+11/-17) snapcraft/plugins/python3.py (+11/-17) snapcraft/plugins/qml.py (+2/-3) snapcraft/plugins/roscore.py (+0/-1) snapcraft/plugins/scons.py (+2/-3) snapcraft/plugins/tar_content.py (+2/-2) snapcraft/sources.py (+12/-18) snapcraft/tests/test_base_plugin.py (+19/-41) snapcraft/tests/test_copy_plugin.py (+7/-9) snapcraft/tests/test_lifecycle.py (+8/-35) snapcraft/tests/test_meta.py (+4/-0) snapcraft/tests/test_sources.py (+2/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~sergiusens/snapcraft/1481122 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Plugins raise exception instead of true/false
To post a comment you must log in.
Revision history for this message
| Sergio Schvezov (sergiusens) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just one needs information because I don't understand one of the changes.
I love the rest, thanks a lot!