lp://staging/~sergiusens/snapcraft/1481122

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~snappy-dev/snapcraft/core at revision 252

Leo Arias (community): Approve on 2015-10-26

Diff: 1075 lines (+146/-292)

25 files modified

snapcraft/__init__.py (+3/-15)
snapcraft/cmds.py (+9/-5)
snapcraft/common.py (+1/-1)
snapcraft/lifecycle.py (+9/-36)
snapcraft/meta.py (+2/-5)
snapcraft/plugins/ant.py (+4/-8)
snapcraft/plugins/autotools.py (+6/-7)
snapcraft/plugins/catkin.py (+12/-34)
snapcraft/plugins/cmake.py (+3/-2)
snapcraft/plugins/copy.py (+4/-10)
snapcraft/plugins/go.py (+7/-9)
snapcraft/plugins/make.py (+2/-2)
snapcraft/plugins/maven.py (+4/-10)
snapcraft/plugins/python2.py (+11/-17)
snapcraft/plugins/python3.py (+11/-17)
snapcraft/plugins/qml.py (+2/-3)
snapcraft/plugins/roscore.py (+0/-1)
snapcraft/plugins/scons.py (+2/-3)
snapcraft/plugins/tar_content.py (+2/-2)
snapcraft/sources.py (+12/-18)
snapcraft/tests/test_base_plugin.py (+19/-41)
snapcraft/tests/test_copy_plugin.py (+7/-9)
snapcraft/tests/test_lifecycle.py (+8/-35)
snapcraft/tests/test_meta.py (+4/-0)
snapcraft/tests/test_sources.py (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1481122: plugin methods return True

Medium

Fix Released

Link a bug report

Related blueprints

254. By Sergio Schvezov on 2015-10-26

Reverting a rogue change

253. By Sergio Schvezov on 2015-10-26

Improve the base plugin's pull logic

252. By Sergio Schvezov on 2015-10-21

Move lifecycle exception handling to not lose data (__str__())

251. By Sergio Schvezov on 2015-10-21

Plugins raise exception instead of true/false

250. By Sergio Schvezov on 2015-10-20

Query the apt cache to verify if a package is installed or not by sergiusens approved by mvo

249. By Sergio Schvezov on 2015-10-20

Add support for maven options by sergiusens approved by chipaca

248. By Sergio Schvezov on 2015-10-20

Rename snapcraft.plugin to snapcraft.lifecycle by sergiusens approved by elopio

247. By Sergio Schvezov on 2015-10-19

Document and cleanup the plugin base class

This cleans up the base class to only expose things plugins will need, since the basic schema includes 'source' options it makes sense for pull to implement that as well automatically if supported.

This also moves everything from the base plugin the plugin.py (which should be renamed to lifecycle.py in a future MP, this one is already too big) and any other thing to its own supporting class.

This branch also includes all the plugin cleanup required for things to keep on working. by sergiusens approved by elopio,chipaca

246. By Daniel Holbach on 2015-10-19

add python3-autopilot as build-depends by dholbach approved by sergiusens

245. By Ted Gould on 2015-10-19

Fixes needed for some autotools builds by ted approved by sergiusens