Code review comment for lp://staging/~senan/ubuntu-autopilot-tests/DiskUsageAnalyser

> This is really making progress now, nice work. THere is just a couple more
> things that need tweaking,

Thank you very much for the review :)
>
> 1) The test script formatting is a little whacky, it looks like you have been
> using 8 space tab characters for part of it, ideally you should set this to 4
> spaces.

I've fixed the spacing issue
>
> 2) When entering /home/ in the file chooser dialog it doesn't seem to close
> beacause of the autocompletion box being open, you need to make sure after
> typing either press 'Delete' so the autocompletion box closes or double click
> the _open button. It would also be good to assert that the PathBar in the
> dialog is in the /Home directory.

I've already implemented the code for removing auto-completion

editBox = self.app.select_single('GtkFileChooserEntry')
  #self.keyboard.focused_type(editBox)
  self.assertThat(editBox.is_focus,Equals(True))
  self.keyboard.type(key_input)
  sleep(2)
  self.keyboard.press_and_release('Delete')
  self.assertThat(editBox.text,Equals(key_input))

I am not sure why the auto-completion box is still showing even after this.. can you please check that. Also I didnt understand assert /Home in pathbar.PathBar in filechooserDlg or after clicking _open button
>
> 3) With regards to checking the ring and bar charts igf you look in vis their
> visible property is always set to true even when not visible, so asserting
> it's visible isn't gaining us anything. We should try and find another way to
> assert they are visible

I couldn't find any other propery to validate in this case..:( .. need your help
>
> If you can make these changes then i think we are nearly there :-) Nice One!