Code review comment for lp://staging/~sdeziel/squid-deb-proxy/remove-unused-acls

Revision history for this message
Michael Vogt (mvo) wrote :

On Mon, Apr 23, 2012 at 04:19:23PM -0000, Simon Déziel wrote:
> > Thanks for your branch! From reading the linked mail it appears this is done
> > in squid3, but currently squid-deb-proxy supports squid2 as well. Would
> > removing those ACLs cause issues with squid2?
>
> The ACL for 'all' appeared in squid3 only. AFAIK, Precise no longer ship squid2 though.

Aha, thanks! Yes, this makes sense then. Now that there is no squid2
anymore in ubuntu we can indeed remove it and more stuff as
well. Would you be interessted to work on the no longer squid/squid3
bits in the code? If not I will, but it will probably take ~2 weeks or
so as I'm traveling soon.

Thanks,
 Michael

« Back to merge proposal