Code review comment for lp://staging/~schwuk/checkbox/cts-iter_6-item_74

Revision history for this message
Marc Tardif (cr3) wrote :

I think that the media_after_suspend test is too general:

+ Are all media card readers still working?

Instead, I would create a test for each media type which would depend on both sleep_state_test and the respective media card tests. At least, if the first media tests are skipped, then the corresponding test after suspend will never be prompted. So, this would cover being overly annoying to the enduser and also being strictly relevant to the tests which were initially performed by the user. What do you think?

review: Approve

« Back to merge proposal