Unity Videos Lens

Merge lp://staging/~saviq/unity-lens-video/remote-videos-scope-plurals into lp://staging/~jhodapp/unity-lens-video/remote-videos-scope-trunk

  1. remote-videos-scope-plurals
  2. Merge into remote-videos-scope-trunk
Proposed by Michał Sawicz
Status: Merged
Approved by: Jim Hodapp
Approved revision: 65
Merged at revision: 59
Proposed branch: lp://staging/~saviq/unity-lens-video/remote-videos-scope-plurals
Merge into: lp://staging/~jhodapp/unity-lens-video/remote-videos-scope-trunk
Diff against target: 112 lines (+24/-35)
1 file modified
src/unity-scope-video-remote (+24/-35)
To merge this branch: bzr merge lp://staging/~saviq/unity-lens-video/remote-videos-scope-plurals
Reviewer Review Type Date Requested Status
Jim Hodapp code Approve
Review via email: mp+121609@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~saviq/unity-lens-video/remote-videos-scope-plurals updated
59. By Michał Sawicz

Use ngettext and str.join in details retrieval

Use ngettext in multivalued details for plural handling
Use str.join to join multivalued details

60. By Michał Sawicz

Don't differentiate between sources

Display all data in the preview, if available, regardless of the source.

61. By Michał Sawicz

Don't use list.get when unnecessary

62. By Michał Sawicz

Only import datetime from datetime

63. By Michał Sawicz

Another dict.get vs dict[]

64. By Michał Sawicz

And another one

Revision history for this message
Jim Hodapp (jhodapp) wrote :

This looks good, but revision 60 needs to be undone since we do need to differentiate between sources given that not every video preview looks the same according to the design mockups.

review: Needs Fixing (code)
lp://staging/~saviq/unity-lens-video/remote-videos-scope-plurals updated
65. By Michał Sawicz

Revert r60

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good!

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: