Code review comment for lp://staging/~saviq/unity-2d/unmaximize-on-drag
Revision history for this message
| Ugo Riboni (uriboni) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
Hey Michal, good to see your contributions again :)
Sorry if it took a while to review this one, but UDS was in the way last week.
Functionally it works well, besides the issue you mention when dragging.
There's just one small glitch that I sometimes notice with gnome-terminal windows: they don't un-maximize to the same size they were before randomly. But i have not seen any other app do that, so it might be some other weird quirk of gnome-terminal.
May I suggest that while you try to figure out what is that is making the drag not work properly you split off the part of the patch that just takes care of the double click and submit that for review so that it can be taken in ? It's already a good improvement over not having neither doubleclick nor drag.
Some comment on code style will follow below.