Thanks for your work. It works well here, but there are a few changes in the code I would like to suggest:
- The code you added to ClosedMenuBarHelper should be in MenuBarWidget: I would like ClosedMenuBarHelper to remain a small helper class to notice when a menu in the menubar is closed.
- Prefer using "const QPoint&" instead of "QPoint*" in WindowHelper::drag() and in MenuBarWidget::menuBarDragged(). Using QPoint* makes it look like the code is going to modify the point.
- Prefer using a forward declaration of QPoint class in windowhelper.h instead of #including it.
- I am worried with r564: it looks like a duplication of the code you added in MenuBarWidget. Maybe it is possible to do most of the work from MenuBarApplet?
Hi Michał,
Thanks for your work. It works well here, but there are a few changes in the code I would like to suggest:
- The code you added to ClosedMenuBarHelper should be in MenuBarWidget: I would like ClosedMenuBarHelper to remain a small helper class to notice when a menu in the menubar is closed.
- Prefer using "const QPoint&" instead of "QPoint*" in WindowHelper: :drag() and in MenuBarWidget: :menuBarDragged (). Using QPoint* makes it look like the code is going to modify the point.
- Prefer using a forward declaration of QPoint class in windowhelper.h instead of #including it.
- I am worried with r564: it looks like a duplication of the code you added in MenuBarWidget. Maybe it is possible to do most of the work from MenuBarApplet?