QtMir

Merge lp://staging/~saviq/qtmir/use-qstandardpaths-cache into lp://staging/qtmir

  1. use-qstandardpaths-cache
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 436
Merged at revision: 447
Proposed branch: lp://staging/~saviq/qtmir/use-qstandardpaths-cache
Merge into: lp://staging/qtmir
Diff against target: 60 lines (+15/-4)
2 files modified
src/modules/Unity/Application/application.cpp (+1/-1)
tests/modules/ApplicationManager/application_manager_test.cpp (+14/-3)
To merge this branch: bzr merge lp://staging/~saviq/qtmir/use-qstandardpaths-cache
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity8 CI Bot (community) continuous-integration Approve
Review via email: mp+282394@code.staging.launchpad.net

Commit message

Use QStandardPaths to determine QML cache location

Also use temporary XDG_CACHE_HOME in ApplicationManagerTests so we don't pollute user's $HOME

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:435
http://jenkins.qa.ubuntu.com/job/qtmir-ci/637/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/331
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/333
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/333/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/213
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/368/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/370/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/213/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/637/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:435
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/1/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/1/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

We actually want GenericCacheLocation and not CacheLocation, no?

review: Needs Fixing
lp://staging/~saviq/qtmir/use-qstandardpaths-cache updated
436. By Michał Sawicz

Use GenericCacheLocation instead

Revision history for this message
Michał Sawicz (saviq) wrote :

> We actually want GenericCacheLocation and not CacheLocation, no?

Fixeded.

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:436
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/39/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/39/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:436
http://jenkins.qa.ubuntu.com/job/qtmir-ci/663/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/357
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/359
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/359/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/239
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/394/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/396/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/239/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/663/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Not the ¿wily? tests

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches