Merge lp://staging/~saviq/qtmir/fix-application-api-deps into lp://staging/qtmir

Proposed by Michał Sawicz
Status: Merged
Approved by: Gerry Boland
Approved revision: 331
Merged at revision: 333
Proposed branch: lp://staging/~saviq/qtmir/fix-application-api-deps
Merge into: lp://staging/qtmir
Diff against target: 45 lines (+5/-3)
3 files modified
CMakeLists.txt (+1/-0)
debian/control (+1/-1)
src/modules/Unity/Application/CMakeLists.txt (+3/-2)
To merge this branch: bzr merge lp://staging/~saviq/qtmir/fix-application-api-deps
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Gerry Boland (community) Approve
Ubuntu Unity PS integration team Pending
Review via email: mp+255839@code.staging.launchpad.net

Commit message

Require an application API version, fix the provided version and use include dir from the .pc file

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Y

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM
 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Y

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches