Code review comment for lp://staging/~saviq/cloud-initramfs-tools/nfs-support

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

On Tue, Apr 9, 2013 at 2:13 PM, Michał Sawicz
<email address hidden> wrote:
> W dniu 09.04.2013 16:05, Scott Moser pisze:
>> Michał,
>> Thanks for this. It generally looks fine to me. I'm OK to pull it into trunk, my only concern is bug 1039402.
>> As I understand it, this is pretty much entirely broken without that bug fix in the kernel, right?
>
> More or less, mounting with server-side locking supposedly helps, but
> you can't actually mount it like that in initramfs, and I couldn't
> remount later, so yeah.
>
>> If so, I'm just weary of pulling in code that is effectively "known broken". I'm not entirely opposed, especially if there is evidence that the kernel issue will be fixed. I'd definitely hold off on including it in ubuntu before raring release though.
>>
>> Thoughts?
>
> Perfectly agree. I mostly put it out there to get a feel whether I'm
> getting anywhere with this. Holding off until the bug is fixed is perfect.

I'm quite intrigued by the feature as well. Nice work. Cool idea. I
agree with publishing the branch and putting it into a holding state
until the kernel bug is fixed.

Cheers,
--
:-Dustin

« Back to merge proposal