Code review comment for lp://staging/~rvb/launchpad/dsd-api-bug-766158

Revision history for this message
Данило Шеган (danilo) wrote :

Looks good. It seems str(Enum) is the right way to pass the enum value around, though it'd be best to check with someone else more knowledgeable as well (i.e. I looked at https://launchpad.net/+apidoc/devel.html for a few enums and they basically expect a string like that).

(fwiw, merging db-devel should not have introduced any other changes into your diff because it is proposed against db-devel, but would introduce bigger differences between Steve's and your branch)

review: Approve

« Back to merge proposal