Code review comment for lp://staging/~rvb/gwacl/add-network-config

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Also, why only retrieve deployment information in the optional "pause" bit? Isn't this something you might as well do anyway, as part of the test?

Arguably it's not useful if you're not pausing, but then again the same goes for creating the virtual machine in the first place. :) If shutdown fails, for example, you might still want to have a closer look at the instance, perhaps using the information you got from GetDeployment.

Finally, would it be worth adding a few words of how-and-why-this-works documentation to ConfigurationSet?

review: Approve

« Back to merge proposal