Code review comment for lp://staging/~rpadovani/webbrowser-app/addressBarFullWidth

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Sorry, but I needed 2 months to understand autopilot :P

Jokes aside, I deleted test_cannot_bookmark_empty_page because when you open a new tab the address bar is focused and users cannot unfocus it, so he can't click anymore the bookmark menu.

I also deleted test_suggestions_hidden_while_drawer_open because now user can't open the drawer while the address bar is focused

I fixed test_selecting_tab_focuses_webview adding a click to the middle of the page to unfocus the address bar

I fixed also test_special_characters adding a delay before the clear button is clicked

test_looses_focus_when_reloading it's a special case: I fixed it (so now it clicks on the button), but fails anywhere: this evidence a real problem. Indeed, on top of some pixels at the center of the reload icon, (where the autopilot presses), there is a MouseArea that activates the tooltip for copy/paste. I spend some time on it, but I didn't understand the root cause. I'll do further investigation in next days. Meanwhile, if you want, try to take a look.

I think is a toolkit bug - for sure it's not an autopilot issue, because I'm able to reproduce it, so before merging that branch I have to fix the problem

« Back to merge proposal