Code review comment for lp://staging/~ronnie.vd.c/ubuntu-website/top-nav

Revision history for this message
Ronnie (ronnie.vd.c) wrote :

There is al least one bug in website-content for it https://bugs.launchpad.net/ubuntu-website-content/+bug/680814. The request came from loco.ubuntu.com, but why not share the code with the whole community. Its like all the other code in the base-theme: use it when you need it, leave it out when you dont need.

I can imagine there are loco's who would also like to have a top bar. So why not include it in the base-theme. Also, each loco/website can decide which links they place in the top-nav, as long the top-nav is consistent on the whole domain.

Also the login is optional, it is possible to place the login on other parts of the webpage, the base-theme does not force you to have it in the top-left corner. But if the domain has a lot of different apps, then i think its good to have to login button on the same place each page (single sign-on should be awsome, but thats usually too much work for a loco)
NOTE: a user can be confused when he/she is logged-in at one app, but needs to login on the other.

« Back to merge proposal