Reviewers: mp+128522_code.launchpad.net,
Message: Please take a look.
Description: lbox: don't panic on error
https://code.launchpad.net/~rogpeppe/lbox/fix-panic-on-error/+merge/128522
(do not edit description out of merge proposal)
Please review this at https://codereview.appspot.com/6632043/
Affected files: [revision details] rietveld.go
Index: [revision details] === added file '[revision details]' --- [revision details] 2012-01-01 00:00:00 +0000 +++ [revision details] 2012-01-01 00:00:00 +0000 @@ -0,0 +1,2 @@ +Old revision: <email address hidden> +New revision: <email address hidden>
Index: rietveld.go === modified file 'rietveld.go' --- rietveld.go 2012-03-15 02:05:35 +0000 +++ rietveld.go 2012-10-08 15:20:33 +0000 @@ -29,9 +29,10 @@ issue.Description = description issue.ReviewerMails = []string{mp.Email()} } else { - issue, err = rietveld.CodeReview.Issue(issue.Id) + id := issue.Id + issue, err = rietveld.CodeReview.Issue(id) if err != nil { - return nil, fmt.Errorf("Can't load issue %d from codereview: %v", issue.Id, err) + return nil, fmt.Errorf("Can't load issue %d from codereview: %v", id, err) } if issue.Description != description { issue.Subject = log.Summary
« Back to merge proposal
Reviewers: mp+128522_ code.launchpad. net,
Message:
Please take a look.
Description:
lbox: don't panic on error
https:/ /code.launchpad .net/~rogpeppe/ lbox/fix- panic-on- error/+ merge/128522
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/6632043/
Affected files:
[revision details]
rietveld.go
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: rietveld.go Description = description ReviewerMails = []string{ mp.Email( )} CodeReview. Issue(issue. Id) CodeReview. Issue(id)
=== modified file 'rietveld.go'
--- rietveld.go 2012-03-15 02:05:35 +0000
+++ rietveld.go 2012-10-08 15:20:33 +0000
@@ -29,9 +29,10 @@
issue.
issue.
} else {
- issue, err = rietveld.
+ id := issue.Id
+ issue, err = rietveld.
if err != nil {
- return nil, fmt.Errorf("Can't load issue %d from codereview: %v",
issue.Id, err)
+ return nil, fmt.Errorf("Can't load issue %d from codereview: %v", id,
err)
}
if issue.Description != description {
issue.Subject = log.Summary