Code review comment for lp://staging/~rogpeppe/juju-core/configuration-alternative

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+114870_code.launchpad.net, fwereade,

Message:
On 2012/07/13 16:08:14, fwereade wrote:
> Much nicer approach in general, more than happy to toss mine out; but
definitely

thanks for the positive review. i will add some tests and address your
comments on monday.

Description:
environs: add configuration attributes and access

This is an alternative possibility to
https://codereview.appspot.com/6353092/

https://code.launchpad.net/~rogpeppe/juju-core/configuration-alternative/+merge/114870

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6343107/

Affected files:
   A [revision details]
   M cmd/juju/cmd_test.go
   M cmd/juju/deploy_test.go
   M cmd/juju/main_test.go
   M environs/config/auth.go
   M environs/config/auth_test.go
   A environs/config/config.go
   A environs/config/export_test.go
   M environs/config_test.go
   M environs/dummy/environs.go
   M environs/ec2/config.go
   M environs/ec2/config_test.go
   M environs/ec2/ec2.go
   M environs/ec2/export_test.go
   M environs/interface.go
   M environs/jujutest/livetests.go
   M environs/tools_test.go
   M juju/conn_test.go
   M state/ssh_test.go

« Back to merge proposal