Code review comment for lp://staging/~rogpeppe/juju-core/311-juju-bootstrap-state-change-password-1.5

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+165675_code.launchpad.net,

Message:
Please take a look.

Description:
cmd/jujud: do not change password

This prepares the way for the password to be changed
when connecting to the API instead of the state.

We also change bootstrap-state to change the machine
agent's password, so the bootstrap machine agent
won't *need* to change its password, and hence won't
need a connection to the at-that-time-nonexistent
API server.

Until agents are actually connecting to the API,
juju will be a tiny bit less secure, so I plan on
waiting until that's ready to land before landing this
branch.

https://code.launchpad.net/~rogpeppe/juju-core/311-juju-bootstrap-state-change-password-1.5/+merge/165675

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9738043/

Affected files:
   A [revision details]
   M cmd/juju/bootstrap_test.go
   M cmd/jujud/agent.go
   M cmd/jujud/agent_test.go
   M cmd/jujud/bootstrap.go
   M cmd/jujud/bootstrap_test.go
   M cmd/jujud/machine_test.go
   M cmd/jujud/unit_test.go
   M environs/agent/agent.go
   M environs/agent/agent_test.go
   M environs/cloudinit/cloudinit.go
   M environs/dummy/environs.go
   M juju/testing/conn.go

« Back to merge proposal