Code review comment for lp://staging/~rogpeppe/juju-core/293-status-life
Revision history for this message
| Roger Peppe (rogpeppe) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
Please take a look.
https:/
File cmd/juju/status.go (right):
https:/
cmd/juju/
On 2013/04/18 12:37:09, fwereade wrote:
> I don't really feel this is a win over the out params.
i think it wins *just*
better would be to have an embedded struct, but i'm not sure goyaml
supports that currently. this is one step towards that.
https:/
cmd/juju/
On 2013/04/18 12:37:09, fwereade wrote:
> Why don't we set the instance id in the other branch?
Done.
https:/
cmd/juju/
On 2013/04/18 12:37:09, fwereade wrote:
> There is no instance. "if no instance has been provisioned" would be
correct, I
> think.
Done.
https:/
cmd/juju/
unprovisioned machines
On 2013/04/18 12:37:09, fwereade wrote:
> also makes unprovisioned machines visually distinct in the output.
Done.
https:/
cmd/juju/
On 2013/04/18 12:37:09, fwereade wrote:
> Why hide errors?
we don't. the error is returned.
https:/
cmd/juju/
On 2013/04/18 12:37:09, fwereade wrote:
> "We don't bother to check agent liveness, even though that is useful
and
> relevant information, because we haven't explicitly agreed what we
should do
> with it."
is it really useful and relevant?
if the status is pending, will we ever see a live agent, given that
changing the status is presumably the first thing an agent actually
does? (and if it doesn't, then it jolly well should)
https:/
cmd/juju/
On 2013/04/18 12:37:09, fwereade wrote:
> I'd rather see 100x "watcher is dying" errors than to just skip it
entirely.
we're not skipping it. it gets returned and put into the entity Err
field.
https:/