Code review comment for lp://staging/~rogpeppe/gozk/zk-error-fixes

Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+83816_code.launchpad.net, niemeyer,

https://codereview.appspot.com/5440056/diff/1/zk_test.go
File zk_test.go (right):

https://codereview.appspot.com/5440056/diff/1/zk_test.go#newcode305
zk_test.go:305: c.Assert(len(children), Equals, 0)
On 2011/11/29 17:32:33, niemeyer wrote:
> IsNil?

yeah. and the NotNil error assertion is probably not necessary either.

Description:
gozk/zk: fixes for new error type

https://code.launchpad.net/~rogpeppe/gozk/zk-error-fixes/+merge/83816

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5440056/

Affected files:
   M retry_test.go
   M server.go
   M suite_test.go
   M zk.go
   M zk_test.go

« Back to merge proposal