Description:
I am concerned at how complex the test for this is,
relative to the simplicity of the actual code change.
(and it's also potentially fragile on a heavily loaded machine).
That said, I can't think of another way to test the
operations directly, so I'm leaving it in.
Better suggestions welcome.
Reviewers: mp+94812_ code.launchpad. net,
Message:
Please take a look.
Description:
I am concerned at how complex the test for this is,
relative to the simplicity of the actual code change.
(and it's also potentially fragile on a heavily loaded machine).
That said, I can't think of another way to test the
operations directly, so I'm leaving it in.
Better suggestions welcome.
https:/ /code.launchpad .net/~rogpeppe/ gozk/safe- close/+ merge/94812
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/5699093/
Affected files:
A close_test.go
M retry_test.go
M suite_test.go
M zk.go
M zk_test.go