Mir

Code review comment for lp://staging/~robertcarr/mir/xkbcommon-mapper

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> It would probably be easier to read and less error-prone if you just defined a
> function or macro...
>
> uint32_t xkb_scancode(uint32_t evdev_scancode)
> {
> return evdev_scancode + 8;
> }
>
> That would be preferred. But I won't block the proposal on it.

+1

review: Approve

« Back to merge proposal