Code review comment for lp://staging/~robertcarr/mir/xkbcommon-mapper

Sorry, I just realized the global:

283 +// xkb scancodes are offset by 8 from evdev scancodes for compatibility with X protocol.
284 +static uint32_t const xkb_scancode_offset_from_evdev = 8;

It would probably be easier to read and less error-prone if you just defined a function or macro...

uint32_t xkb_scancode(uint32_t evdev_scancode)
{
    return evdev_scancode + 8;
}

That would be preferred. But I won't block the proposal on it.