Mir

Code review comment for lp://staging/~robertcarr/mir/xkbcommon-mapper

Revision history for this message
Kevin DuBois (kdub) wrote :

304 + xkb_context *context;
305 + xkb_keymap *map;
306 + xkb_state *state;

can we use custom deleters instead of the destructor?

+ uint32_t xkb_scan_code = scan_code + 8;
comment/macro/constant to explain the 8

do we need to update the android helper scripts to download the new dependency?

review: Needs Fixing

« Back to merge proposal