Mir

Code review comment for lp://staging/~robertcarr/mir/socket-messenger-reporting

Revision history for this message
Kevin DuBois (kdub) wrote :

i can't decide if we need a new report for this... seems if a message fails to send, the component that intended to send the message would care about knowing that. So, if there's an error sending, we could throw where we report an error in this MP... and the protobuf message processor could log that (it already has a logging class). the protobuf message processor could then rethrow and we'd clean up the resources for that client. Or, if the shell wanted to send a MirEvent, it could take appropriate action if that failed to send.

« Back to merge proposal