Mir

Code review comment for lp://staging/~robertcarr/mir/i-love-deduping-mocks

  1. i-love-deduping-mocks
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Du-duplication is awesome, but the result is confusing:
>
> class MockShell : public mtd::MockShell
>
> Two MockShell classes?

I'm not entirely convinced by Robert's mission to remove all duplication (see link below) and this is a case too confusing.

http://programmer.97things.oreilly.com/wiki/index.php/Beware_the_Share

review: Needs Fixing

« Back to merge proposal